Michael Kujawa
19-Mar-2008, 11:17 AM
I'm using the default colors, where a left change is blue, a right change is purple, and a difference is red or orange. I'm seeing some unexpected behavior in build 447: (Since I don't see how to change the background color in vBulletin, I'll demonstrate with a foreground color change.)
Left File: Right File:
#endif #endif
/////////////////////////////////////////// // Explain why foo is allowed to fail
if ( !foo() ) foo();
{ ///////////////////////////////////////////
HandleError(); /////////////////////////////////////////// } ///////////////////////////////////////////
else ///////////////////////////////////////////
{ ///////////////////////////////////////////
HandleSuccess(); HandleSuccess();
} ///////////////////////////////////////////
Cirrus correctly matched the #endif, correctly matched the if ( !foo() ) to the foo() call, andcorrectly matched the HandleSuccess lines; but I was suprised at what it did to the comment. It's being treated as a "Line w/ unimportant different changes", and I was expecting a "Line w/ unimportant right changes".
Which is the correct behavior?
Left File: Right File:
#endif #endif
/////////////////////////////////////////// // Explain why foo is allowed to fail
if ( !foo() ) foo();
{ ///////////////////////////////////////////
HandleError(); /////////////////////////////////////////// } ///////////////////////////////////////////
else ///////////////////////////////////////////
{ ///////////////////////////////////////////
HandleSuccess(); HandleSuccess();
} ///////////////////////////////////////////
Cirrus correctly matched the #endif, correctly matched the if ( !foo() ) to the foo() call, andcorrectly matched the HandleSuccess lines; but I was suprised at what it did to the comment. It's being treated as a "Line w/ unimportant different changes", and I was expecting a "Line w/ unimportant right changes".
Which is the correct behavior?