PDA

View Full Version : Unexpected difference coloring


Michael Kujawa
19-Mar-2008, 11:17 AM
I'm using the default colors, where a left change is blue, a right change is purple, and a difference is red or orange. I'm seeing some unexpected behavior in build 447: (Since I don't see how to change the background color in vBulletin, I'll demonstrate with a foreground color change.)


Left File: Right File:
#endif #endif
/////////////////////////////////////////// // Explain why foo is allowed to fail
if ( !foo() ) foo();
{ ///////////////////////////////////////////
HandleError(); /////////////////////////////////////////// } ///////////////////////////////////////////
else ///////////////////////////////////////////
{ ///////////////////////////////////////////
HandleSuccess(); HandleSuccess();
} ///////////////////////////////////////////


Cirrus correctly matched the #endif, correctly matched the if ( !foo() ) to the foo() call, andcorrectly matched the HandleSuccess lines; but I was suprised at what it did to the comment. It's being treated as a "Line w/ unimportant different changes", and I was expecting a "Line w/ unimportant right changes".

Which is the correct behavior?

Michael Kujawa
19-Mar-2008, 11:28 AM
I see what's up: I'd installed on a new machine and forgotten to set the "Orphans are sided change". I think I've been through this before and forgotten, too. Sorry for the spam.

Michael Kujawa
19-Mar-2008, 11:47 AM
One thing that IS different is that the unimportant diffs show up on the ruler the same as important diffs, instead of as just a little green tick. Was that intentional? Is that another option somewhere?

Tim
19-Mar-2008, 12:17 PM
I think you have Ignore Unimportant Differences enabled, and you are seeing green ticks on the Thumbnail display for unimportant differences.

For some time, ignored unimportant differences have been handled just like using the manual Ignored command on any difference. We will be separating the two concepts in an upcoming release.

Michael Kujawa
19-Mar-2008, 12:34 PM
Ah yep, that's it. New machines can be such a pain :) Now my diffs look like they used to, thanks!